Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Revert unhandled exception PR for 1.3.0 temporarily #15287

Merged
merged 2 commits into from
Apr 15, 2021
Merged

[WIP] Revert unhandled exception PR for 1.3.0 temporarily #15287

merged 2 commits into from
Apr 15, 2021

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 changed the title Fix problem. [WIP] Revert unhandled exception PR for 1.3.0 temporarily Apr 14, 2021
@rkooo567
Copy link
Contributor Author

cc @wuisawesome

@amogkam
Copy link
Contributor

amogkam commented Apr 14, 2021 •
edited
Loading

@rkooo567 can you please ping me when this is ready to be picked. Thanks.

Nvm this is a PR against the release branch. You can merge directly once CI passes.

@wuisawesome wuisawesome self-assigned this Apr 14, 2021
@rkooo567
Copy link
Contributor Author

Hey @simon-mo Do you know why the buildkite build fails?

@simon-mo
Copy link
Contributor

determine_tests_to_run failed probably because your PR isn't based off releases/1.3.0. Can you run rebase (not merge)?

@rkooo567
Copy link
Contributor Author

@simon-mo It should be based off of release 1.3.0. (I checked out from there). So, here's what I did.

  1. Checked out release 1.3.0 branch.
  2. Checked out to the current branch.
  3. Call revert on the offending commit.
  4. Fixed merge conflict.

@rkooo567
Copy link
Contributor Author

rkooo567 commented Apr 14, 2021 •
edited
Loading

@simon-mo maybe having a quick call?
(I think I should also cherry pick the dm-tree PR)

Conclusion:
Most of build failures seems to be related to the fact that CI is not designed to push PR to the release branch.

@simon-mo @rkooo567
[Hotfix] Pin dm-tree package version (ray-project#15249)
0b76667 
`dm-tree` released a new version https://pypi.org/project/dm-tree/#history
and it depends on `bazel` to build from source, and it conflicts with
our current bazel setup (this conflict is non-trivial to fix).
@rkooo567
Copy link
Contributor Author

Hey @wuisawesome Can you review the PR?

This was referenced Apr 15, 2021
Closed
Closed
@rkooo567
Copy link
Contributor Author

Both windows tests failures are from release 1.3.0 branch. Lint failure and buildkite failure is due to this PR is for release branch according to Simon. test_failure is a known flaky test. Merging it.

@rkooo567 rkooo567 merged commit 61b875e into ray-project:releases/1.3.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuisawesome wuisawesome wuisawesome approved these changes

Assignees

@wuisawesome wuisawesome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkooo567 @amogkam @simon-mo @wuisawesome